Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make console.warn named function #7811

Merged
merged 4 commits into from
Nov 26, 2022
Merged

Make console.warn named function #7811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c76f346
make console.warn named function
wtachau Nov 25, 2022
c4aec7f
fix
Rich-Harris Nov 26, 2022
654e66f
changeset
Rich-Harris Nov 26, 2022
a7a7281
actually i kinda prefer this
Rich-Harris Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/itchy-beers-suffer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Make console.warn wrapper named rather than anonymous
6 changes: 3 additions & 3 deletions packages/kit/src/runtime/client/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1717,8 +1717,8 @@ function reset_focus() {

if (__SVELTEKIT_DEV__) {
// Nasty hack to silence harmless warnings the user can do nothing about
const warn = console.warn;
console.warn = (...args) => {
const console_warn = console.warn;
console.warn = function warn(...args) {
if (
args.length === 1 &&
/<(Layout|Page)(_[\w$]+)?> was created (with unknown|without expected) prop '(data|form)'/.test(
Expand All @@ -1727,6 +1727,6 @@ if (__SVELTEKIT_DEV__) {
) {
return;
}
warn(...args);
console_warn(...args);
};
}