Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip form action tests on webkit build #8570

Closed
wants to merge 1 commit into from

Conversation

dummdidumm
Copy link
Member

fetch requests sometimes for unknown reasons go into the abyss and never fire off, most commonly on webkit during build mode - therefore disable tests there

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

fetch requests sometimes for unknown reasons go into the abyss and never fire off, most commonly on webkit during build mode - therefore disable tests there
@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2023

⚠️ No Changeset found

Latest commit: 8ad5ffe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

I think I'd lean towards opt-in rather than opt-out for the webkit tests. There's a few PRs dealing with this, so I opened an issue so that we can have a single place to discuss: #8578 (or now we have four places instead of three 😆)

@benmccann
Copy link
Member

Closing this since #8585 was merged

@benmccann benmccann closed this Jan 19, 2023
@benmccann benmccann deleted the skip-some-tests branch January 19, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants