Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci - ensure unique test artifacts and correct matrix definition #8615

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

dominikg
Copy link
Member

followup to #8585 to prevent collisions

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023

⚠️ No Changeset found

Latest commit: 5c90e0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title fix: ensure uploaded artifacts have a unique name across test matrixes fix: ensure uploaded artifacts have a unique name across test matrices Jan 19, 2023
@dominikg dominikg changed the title fix: ensure uploaded artifacts have a unique name across test matrices fix: ci - ensure uniqu test artifacts and correct matrix definition Jan 19, 2023
@dominikg dominikg changed the title fix: ci - ensure uniqu test artifacts and correct matrix definition fix: ci - ensure unique test artifacts and correct matrix definition Jan 19, 2023
@Rich-Harris Rich-Harris merged commit a7136c3 into sveltejs:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants