Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow rest parameters to follow multiple optional - or not - parameters #8761

Merged
merged 5 commits into from
Jan 30, 2023

Conversation

Oreilles
Copy link
Contributor

@Oreilles Oreilles commented Jan 28, 2023

Fixes #8601

Actually, managed to clean up the whole thing and make it work with every valid test case I could think of.

It's not pretty (it's not that bad either), but it works.
There's still a case it doesn't solve though, but I'm fairly confident we got time before someone actually goes for such thing.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2023

🦋 Changeset detected

Latest commit: fda3524

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Oreilles Oreilles force-pushed the fix/rest-parameter-routing branch from 6b51940 to 3418fff Compare January 28, 2023 10:00
@Oreilles Oreilles force-pushed the fix/rest-parameter-routing branch from 3418fff to aec8489 Compare January 28, 2023 11:51
@Rich-Harris
Copy link
Member

this is a thing of real beauty — thanks so much! absolutely fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional parameter with matcher followed by a rest parameter route results in 404
2 participants