-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: preserve ./netlify/functions-internal #8899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not totally aware of why the functions-internal directory is emptied currently by this adapter, however, this PR ensures that only the files that are generated by SvelteKit are removed and not any other files.
It was just done to remove any leftover files from previous builds
I have just spotted that the name of the files generated could be dynamic - https://github.com/sveltejs/kit/pull/8899/files#diff-cc76725f3c6f8ff40fb8605aff3b0d3eeefc561e4a6c9a162b79dda99c95dedaL196. |
Thank you! Could you add a changeset? Then we're good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lewis. All looks good 🎉
Added 👍 |
Summary
Some Netlify integrations, such as the emails integration, auto generate functions prior to the build and these will exist in the
functions-internal
folder. I am not totally aware of why thefunctions-internal
directory is emptied currently by this adapter, however, this PR ensures that only the files that are generated by SvelteKit are removed and not any other files.How has this been tested?
netlify build
split:true
and runningnetlify build
againnetlify build
againCloses #8903
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.