Final (I think) stepping stone PR towards #519/#626 #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phew. I think I can start making actual changes to functionality now. The big change here is that each component's entry in the manifest includes the root layout as well as intermediate layouts (if such there be) and the leaf component. This simplifies things a bit but also paves the way for pages to have a different 'root' layout (i.e. the most recent
$layout.reset.sveltecomponent).It also adds specific paths for rendering error pages. This is important because once we have nested error pages, 'render an error page' and 'render a page that happened to error' will be subtly different things; the first always means 'use the default layout/error combination' whereas the second could involve rendering multiple layout components and a specific error leaf component that might not be the default.