fix: successive optional route parameters can now be empty #9266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9261
In the scenario outlined in the linked issue, with 2 chained optional parameters, skipping the first optional parameter would result in a 404.
When the first optional parameter was detected as being missing, a buffer variable was incremented to allow the 2nd parameter to be correctly assigned. However this buffer was never reset (except in the case of a [...rest] parameter being present). This was triggering the
if(buffered) return;
check, resulting in a 404.This change resets the buffer back to 0 in the appropriate circumstance.
The check verifies that the next parameter is not a [...rest] parameter. If it is, we don't reset the buffer in order to trigger the coalescing of remaining values into [...rest].
If it's not a rest parameter, and the next value is defined, then we should reset the buffer to prevent any data loss. This scenario is tested in the following existing test:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.