fix: deal with fast consecutive promise resolutions when streaming #9332
Conversation
| next: async () => { | ||
| const next = await deferred[0].promise; | ||
| if (!next.done) deferred.shift(); | ||
| return next; | ||
| } |
There was a problem hiding this comment.
| next: async () => { | |
| const next = await deferred[0].promise; | |
| if (!next.done) deferred.shift(); | |
| return next; | |
| } | |
| next: deferred.shift().promise |
There was a problem hiding this comment.
This needs a type cast because TS doesn't know this is always defined, and strictly speaking it's not adhering to the spec that says you can call next as much as you want after it's done (it should always return done: true in that state).
| }; | ||
| } | ||
| }, | ||
| push: (value) => { | ||
| deferred.fulfil({ value, done: false }); | ||
| deferred = defer(); | ||
| deferred[deferred.length - 1].fulfil({ |
There was a problem hiding this comment.
| deferred[deferred.length - 1].fulfil({ | |
| deferred.at(-1).fulfil({ |
| }, | ||
| done: () => { | ||
| deferred.fulfil({ done: true }); | ||
| deferred[deferred.length - 1].fulfil({ done: true }); |
There was a problem hiding this comment.
| deferred[deferred.length - 1].fulfil({ done: true }); | |
| deferred.at(-1).fulfil({ done: true }); |
There was a problem hiding this comment.
I had that previously but that requires you to do a stupid type cast because TS says "this might be undefined" and that code was harder to read/longer.
There was a problem hiding this comment.
wait TS thinks array.at(x) might be undefined but array[x] is not? the fuck?
There was a problem hiding this comment.
I think this is mostly due to backwards compatibility to not break existing code bases. They have another flag outside the strict family that turns on the same behavior for array[x]
fixes #9330
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.