Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't start debugger on 404s #9424

Merged
merged 2 commits into from
Mar 15, 2023
Merged

fix: don't start debugger on 404s #9424

merged 2 commits into from
Mar 15, 2023

Conversation

dummdidumm
Copy link
Member

Also directly trigger native navigation for external links to prevent wrong invocation of handleError
closes #9399

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@benmccann benmccann merged commit 385bd49 into master Mar 15, 2023
@benmccann benmccann deleted the handle-404 branch March 15, 2023 21:52
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
@opensas
Copy link

opensas commented Mar 15, 2023

Since now SvelteKit's goto seems to recognize external URLs, can we safely tell users to use goto for internal and also external URLs?

In that case, we should update goto documentation, removing the last sentence (which IMO it's a great plus, one thing less for developers to care about)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants