fix/chore: only skip hydration with vite overlay if current page is an error #9892
Conversation
🦋 Changeset detectedLatest commit: 8f5eb76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -269,7 +269,7 @@ export function create_client(app, target) { | |||
|
|
|||
| /** @param {import('./types').NavigationFinished} result */ | |||
| function initialize(result) { | |||
| if (DEV && document.querySelector('vite-error-overlay')) return; | |||
| if (DEV && result.state.error && document.querySelector('vite-error-overlay')) return; | |||
There was a problem hiding this comment.
There can also be errors when you're not on the error page - so I don't fully understand how this reduces flakiness. Can you explain in more detail?
There was a problem hiding this comment.
There can also be errors when you're not on the error page
This function only runs after navigations or on the initial load and in those cases you would always be on the error page if there is an error (I think).
Since our tests are concurrent, the overlay is created even if the error was meant for another tab and skipping hydration prevents the rest of the test from running.
It's not the ideal solution, but currently Playwright doesn't offer a way to run specific tests without concurrency.
Right now there is one test where the overlay is expected but the overlay causes flakiness in other tests because it is unintentionally broadcasted to them.
This shouldn't have any effect on users I think. But it gets rid of some flakiness in our tests.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.