Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure styles are loaded in dev mode for routes containing special characters #9894

Merged
merged 5 commits into from
May 17, 2023
Merged

fix: ensure styles are loaded in dev mode for routes containing special characters #9894

merged 5 commits into from
May 17, 2023

Commits on May 10, 2023

  1. Fix loading styles for routes containing special characters in dev mode.

    SvelteKit doesn't decode special characters in pathnames when loading CSS modules in dev mode, resulting in an error:
    
    Internal server error: Failed to load url /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte=&type=style&lang.css=&inline= (resolved id: /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte&type=style&lang.css). Does the file exist?
    
    Actual path:
    
    /src/routes/(special)/hinnapäring/
    
    Fix by using decodeURI on the url.pathname when loading CSS modules.
    whataboutpereira committed May 10, 2023
    Configuration menu
    Copy the full SHA
    839aad3 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Configuration menu
    Copy the full SHA
    e4be05e View commit details
    Browse the repository at this point in the history
  2. decodeURL inside if

    whataboutpereira authored May 11, 2023
    Configuration menu
    Copy the full SHA
    7b9f5c9 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. merge master

    Rich Harris committed May 16, 2023
    Configuration menu
    Copy the full SHA
    49068d5 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. add test

    Rich Harris committed May 17, 2023
    Configuration menu
    Copy the full SHA
    cea820e View commit details
    Browse the repository at this point in the history