Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support JSDoc in .svelte files #572

Closed
subz390 opened this issue Sep 25, 2020 · 3 comments
Closed

support JSDoc in .svelte files #572

subz390 opened this issue Sep 25, 2020 · 3 comments
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.

Comments

@subz390
Copy link

subz390 commented Sep 25, 2020

Svelte for VS Code 102.0.0 in VS Code for Windows 10
Would it be easy enough to implement or support JSDoc handling in .svelte files like it is in .js files in VS Code?
I hope the pictures demonstrate the issue, if not I can help explain some more, thanks.

When creating JSDoc comment blocks;
200925-155427 no autocomplete
200925-155601 autocomplete

When using JSDoc;
200925-160345 js file all of the jsdoc
200925-160620 svelte only has summary

@dummdidumm dummdidumm added the feature request New feature or request label Sep 25, 2020
@jasonlyu123
Copy link
Member

We probably have to migrate this one to make the JSDoc hover happen, probably with the license comment. Vetur also has it, making me a bit more comfortable copying the entire file lol.

@jasonlyu123
Copy link
Member

jasonlyu123 commented Oct 13, 2020

Quick update. I have the jsdoc comment template completion working. but not the param type, it works like a typescript file.
圖片
It seems like typescript's language service only provides the type for jsDoc template like @param {} when the file extension is .js or .jsx. So until they change that behavoiur we can only provide it like typescript.

@subz390
Copy link
Author

subz390 commented Oct 13, 2020

Sounds like you have made good progress. Something already reads the parameter type in .svelte files, see my screenshot below.
201013-033622 the parameter types are read

So long as the typescript's language service presents all the other info from the parameters then it'll be ok.

dummdidumm pushed a commit that referenced this issue Oct 16, 2020
@jasonlyu123 jasonlyu123 added the Fixed Fixed in master branch. Pending production release. label Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

3 participants