Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong syntax highlighting on closing angle brackets of opening script and style tags #822

Closed
SamuelCharpentier opened this issue Feb 16, 2021 · 1 comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@SamuelCharpentier
Copy link

the closing angle brackets > of my opening <script> and <stlye> tags is colored wrong and I clearly remember this not being the case a few weeks ago.

To Reproduce
Steps to reproduce the behavior:
In VSCode:

  1. Use a theme where the brackets are not white or grey. Native theme Monokai Dimmed makes this very visible.
  2. Use Svelte for VSCode
  3. Create a .svelte file and use a <style> or <script> tag
  4. Look at the difference between opening and closing angle bracket of opening tag (<style>/*<-- this one*/</style>)

Expected behavior
The closing angle bracket of the opening <style> or <script> tag should be the same color as every other angle brackets.

Screenshots
Monokai Dimmed
image
image
Mariana Pro (cool)
image
image

System (please complete the following information):

  • OS: Windows 10
  • IDE: VSCode
  • Plugin/Package: "Svelte for VSCode"

Additional context
I disabled every other plugin.

@SamuelCharpentier SamuelCharpentier added the bug Something isn't working label Feb 16, 2021
@aradalvand
Copy link

aradalvand commented Feb 19, 2021

Haha, I was just about to open an issue for this very same problem!

Will this be addressed, please?
My OCD doesn't like this at all:

Screenshot 2021-02-19 050646

dummdidumm added a commit that referenced this issue Feb 19, 2021
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

3 participants