-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LS] Suggested import returns string with CRLFs, double quotes and no indent #854
Comments
These options are passed into the typescript language service by us, and it works in VS Code. You likely need to pass TypeScript's user preferences into the language server similar to this. The indent is a different issue indepent of the configuration. |
dummdidumm
pushed a commit
to dummdidumm/language-tools
that referenced
this issue
Mar 19, 2021
Use indentation of first line of imports to determine the indentation of the following lines sveltejs#854
dummdidumm
added a commit
that referenced
this issue
Mar 19, 2021
Use indentation of first line of imports to determine the indentation of the following lines #854
dummdidumm
pushed a commit
that referenced
this issue
Dec 6, 2021
Typescript defaults to CRLF if host.getNewLine is not implemented and if there's no user config #854
dummdidumm
pushed a commit
that referenced
this issue
Aug 30, 2022
With 106.0.0. The behaviour now is:
That check all the boxes. So I think we can close this now. If there's anything I missed, feel free to reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
svelteserver screenshots
Contrary to
tsserver
, which inserts imports without CRLFs and uses quote variant that is prevalent in this file.tsserver screenshots
Edit: I've also tried converting Promise-based function to an async in
svelte
file, it inserts CRLFs too, indent is messed up, but at least it doesn't touch my single quotes: 😄I guess vcsode just autoformats everything after code actions so it goes unnoticed?
My autoformatter doesn't strip CRs from LFs. 🤔
The text was updated successfully, but these errors were encountered: