Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) add workspace trust #1086

Merged
merged 5 commits into from
Jul 8, 2021
Merged

(feat) add workspace trust #1086

merged 5 commits into from
Jul 8, 2021

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 6, 2021 •
edited
Loading

#1051

Marking as draft for now since I want to get feedback from the VS Code team first about backwards compatibility.
If there's no backwards compatibility we need to bump the minimum required VS Code version, which means I'd rather get some more bugfixes/enhancements in, first. Edit: Got the response, we need to bump the minimum required version for this. For me this means:

  1. Add workspace trust in a backwards compatible way first, which means not lifting the "scope": "application" restriction
  2. Wait a month or so, get other bug fixes/features etc in
  3. lift restriction and bump minimum required VS Code version

@dummdidumm dummdidumm marked this pull request as ready for review July 8, 2021 11:34
@dummdidumm dummdidumm merged commit 7abeef4 into sveltejs:master Jul 8, 2021
@dummdidumm dummdidumm deleted the workspace-trust branch July 8, 2021 11:41
@dummdidumm dummdidumm mentioned this pull request Jul 8, 2021
Closed
dummdidumm added a commit that referenced this pull request Jul 10, 2023
@dummdidumm
feat: leverage workspace trust to support all settings in workspace
377095c 
#1051
#678
This was the missing feature in #1086, but now that we have a new minimum required VS Code version which includes workspace trust, we can lift the restriction and allow the security-sensitive settings when the workspace is trusted.
@dummdidumm dummdidumm mentioned this pull request Jul 10, 2023
Merged
dummdidumm added a commit that referenced this pull request Jul 11, 2023
@dummdidumm
feat: leverage workspace trust to support all settings in workspace (#…
fd963fd 
…2089)

#1051
#678
This was the missing feature in #1086, but now that we have a new minimum required VS Code version which includes workspace trust, we can lift the restriction and allow the security-sensitive settings when the workspace is trusted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dummdidumm