Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relax component constructor type #2524

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<script lang="ts" generics="T">
let { value, defaultValue }: { value: T; defaultValue?: T } = $props();
</script>

{value}
{defaultValue}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
[
{
"code": 2322,
"message": "Type 'number' is not assignable to type 'string'.",
"range": {
"end": {
"character": 36,
"line": 10
},
"start": {
"character": 24,
"line": 10
}
},
"severity": 1,
"source": "ts",
"tags": []
}
]
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<script lang="ts">
import ValueComponent from './ValueComponent.svelte';

let value = $state("test");
</script>

<!-- ok -->
<ValueComponent {value} defaultValue={"foo"} />

<!-- error -->
<ValueComponent {value} defaultValue={1} />
2 changes: 1 addition & 1 deletion packages/svelte2tsx/svelte-shims-v4.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ declare type ATypedSvelteComponent = {
*/
$$slot_def: any;

$on(event: string, handler: ((e: any) => any) | null | undefined): () => void;
$on(event: string, handler: any): () => void;
}
/**
* Ambient type only used for intellisense, DO NOT USE IN YOUR PROJECT.
Expand Down