Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion for ids/classes in the template #844

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

jasonlyu123
Copy link
Member

completion for ids/classes in the template that are present in CSS
圖片

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! One thing that could help the visibility of this feature is to trigger the completion on space or ", but we would have to make sure that this does not result in too much autocompletion noise and also make sure that it will not negatively affect other completion participants (they'd need to filter that trigger character out). --> we can do that in another PR if we have the time/want it.

@dummdidumm dummdidumm merged commit 214d105 into sveltejs:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants