Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(perf) improve svelte-check performance #872

Merged
merged 3 commits into from
Mar 11, 2021
Merged

(perf) improve svelte-check performance #872

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e50ea32
improve svelte-check performance
jasonlyu123 Mar 10, 2021
8709963
fix condition
jasonlyu123 Mar 10, 2021
704de05
update ts doc immediately when document open
jasonlyu123 Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/language-server/src/plugins/typescript/LSAndTSDocResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,24 @@ export class LSAndTSDocResolver {
private readonly configManager: LSConfigManager,
private readonly transformOnTemplateError = true
) {
const handleDocumentChange = (document: Document) => {
// This refreshes the document in the ts language service
this.getLSAndTSDoc(document);
};
docManager.on(
'documentChange',
debounceSameArg(
async (document: Document) => {
// This refreshes the document in the ts language service
this.getLSAndTSDoc(document);
},
handleDocumentChange,
(newDoc, prevDoc) => newDoc.uri === prevDoc?.uri,
1000
)
);

// New files would cause typescript to rebuild its type-checker.
// Open it immediately to reduce rebuilds in the startup
// where multiple files and their dependencies
// being loaded in a short period of times
docManager.on('documentOpen', handleDocumentChange);
}

/**
Expand Down