(feat) support ESM configs #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 31, 2021 19:06
using dynamic import statements. In preparation for ESM config support.
|
I'll take a look next week. |
dummdidumm
added a commit
that referenced
this pull request
Apr 7, 2021
Node versions prior to v12.17 need the `--experimental-modules` flag or the dynamic import introduced in #930 won't work. This node version is used in VS Code versions prior to 1.55 and could be used by users setting the node executable to a node version below 12.17. Remove this in mid 2022 and bump vs code minimum required version to 1.55
|
This is the greatest PR I've ever seen in my life (well, in the last month anyways). Any idea what release this will be a part of? It doesn't look like this is working yet as of |
|
I think SvelteKit is hardcoded to using |
|
Ah, gotcha. I was linked to this PR from the Discord and didn't pay attention to what repo this is in. Either way, super great work! I hope this is able to land in Kit eventually, it would make my life (and hopefully other's) a LOT easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR config loading switches to using dynamic import statements. The PR consists of
make this function asyncmodifications since the ts service initialization is now asyncSupport ESM Syntax in config files #509