-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preprocessor sourcemap #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be implemented in such a way that it does not fail with older versions of Svelte, and it doesn't look like this was done. The compiler throws an exception on unknown compiler options. If you have to bump the version of Svelte in order for existing tests to pass, then as implemented this is a breaking change.
Did the response from |
I believe the response to |
I think this should be okay because it would pass |
The compiler throws if an unknown key is present in the options object, even if its value is |
6751e5b
to
c419611
Compare
updated. thanks for taking a look! |
No description provided.