feat(hn): update deps, edge based #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PuruVJ
commented
Jul 11, 2023
PuruVJ
commented
- Updates deps of hn.svelte.dev
- Switches to using edge runtime for faster performance and less impact on environment
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benmccann
reviewed
Jul 11, 2023
benmccann
reviewed
Jul 11, 2023
benmccann
reviewed
Jul 11, 2023
benmccann
reviewed
Jul 11, 2023
| export async function load({ params, fetch }) { | ||
| const res = await fetch(`https://api.hnpwa.com/v0/user/${params.name}.json`); | ||
| return res.json(); | ||
| return fetch(`https://api.hnpwa.com/v0/user/${params.name}.json`).then((r) => r.json()); |
There was a problem hiding this comment.
making it one line makes sense, but why not use await still?
Suggested change
| return fetch(`https://api.hnpwa.com/v0/user/${params.name}.json`).then((r) => r.json()); | |
| return (await fetch(`https://api.hnpwa.com/v0/user/${params.name}.json`)).json(); |
There was a problem hiding this comment.
I dunno, await has felt weird when surrounded by brackets. .then feels cleaner for this case somehow
There was a problem hiding this comment.
What happens if invalid JSON is returned from the API? I think the two ways of writing it would behave differently, but I'm not exactly sure what the behavior of the .then() version is
There was a problem hiding this comment.
It's the same. If it errors, then .json() errors out, giving the same error as await version
benmccann
reviewed
Jul 17, 2023
benmccann
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.