feat: add firefox support #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging the cross-browser manifest trick to get the background script running. Note that Firefox will show a warning when we try to load it as a temporary add-on, but we can safely ignore the message and the extension will still work as expected
Svelte website detection will not work in Firefox because we can't get the
versionfrom the"MAIN"world as it is not supported yet (Bug 1736575). Moving it as content script doesn't seem to work as we need it to execute on tab and URL changes as well, not just the initial load. Tried a lot of other things but it gets too complicated and doesn't seem to be worth the effort.Closes #177