Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: specify add-on id #192

Merged
merged 1 commit into from
Apr 4, 2024
Merged

feat: specify add-on id #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions static/.web-extension-id
View file
Open in desktop

This file was deleted.

9 changes: 8 additions & 1 deletion static/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,12 @@
"devtools_page": "register.html",
"host_permissions": ["*://*/*"],
"permissions": ["activeTab", "scripting"],
"web_accessible_resources": [{ "matches": ["*://*/*"], "resources": ["courier.js"] }]
"web_accessible_resources": [{ "matches": ["*://*/*"], "resources": ["courier.js"] }],

"browser_specific_settings": {
"gecko": {
"id": "firefox-devtools@svelte.dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit long and so doesn't look that nice to me when written out. How about just svelte.dev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might've tried that and it failed as it needs to either be a GUID or string formatted like an email address per https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings#firefox_gecko_properties

I can try and see if @svelte.dev works by tomorrow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting. If we have to use a @ then I might suggest devtools@svelte.dev. Just @svelte.dev looks a bit funny to me

Copy link
Member Author

@ignatiusmb ignatiusmb Apr 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did use devtools@svelte.dev at first when I tried to publish it on addons.mozilla.org, but it conflicts with the old one as we discussed in Discord. Reuploading it for the "distributing on your own" doesn't work since the ID has been registered, and we can't reuse the ID according to their policy, so we need another unique ID

image

It does seem like it's only used internally, so a random GUID like "{daf44bf7-a45e-4450-979c-91cf07434c3d}" would also do the job, and @svelte.dev seems to work too if we want to opt for a really short one.

P.S. I did a test run and submitted this to see if there's any other issue, and I just got the confirmation for the extension submitted with firefox-devtools@svelte.dev has been approved and signed. We can do another reupload with a different ID to finalize this if it ends up different.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought it was just plain svelte that the old one was using as it's id

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll merge this so that we can get a signed add-on install file for Firefox on the next release

"strict_min_version": "121.0"
}
}
}
Loading