Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve svelte/shared.js #65

Closed
Rich-Harris opened this issue May 17, 2018 · 0 comments · Fixed by #69
Closed

resolve svelte/shared.js #65

Rich-Harris opened this issue May 17, 2018 · 0 comments · Fixed by #69
Labels

Comments

@Rich-Harris
Copy link
Member

it's possible for a third party component to try and import the wrong version of Svelte.
Changing this line should fix it:

+const relative = require('relative-require');

// later...

-if (!('shared' in options)) options.shared = options.format === 'es' && 'svelte/shared.js';
+if (!('shared' in options)) options.shared = options.format === 'es' && relative.resolve('svelte/shared.js', process.cwd());
ekhaled added a commit to ekhaled/svelte-loader that referenced this issue Aug 24, 2018
@ekhaled ekhaled mentioned this issue Aug 24, 2018
Rich-Harris added a commit that referenced this issue Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant