chore: upgrade magic-string (#9292)

sveltejs · Oct 4, 2023 · 052d381 · 052d381 · vercel · Oct 4, 2023
1 parent 9ffe07d
commit 052d381
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 52 deletions.
diff --git a/.changeset/sour-rats-laugh.md b/.changeset/sour-rats-laugh.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+chore: upgrade magic-string to 0.30.4
diff --git a/packages/svelte/package.json b/packages/svelte/package.json
@@ -114,7 +114,7 @@
     "estree-walker": "^3.0.3",
     "is-reference": "^3.0.1",
     "locate-character": "^3.0.0",
-    "magic-string": "^0.30.0",
+    "magic-string": "^0.30.4",
     "periscopic": "^3.1.0"
   },
   "devDependencies": {

diff --git a/packages/svelte/test/sourcemaps/samples/compile-option-dev/test.js b/packages/svelte/test/sourcemaps/samples/compile-option-dev/test.js
@@ -21,18 +21,15 @@ export async function test({ assert, css, js }) {
 	const sourcefile = 'input.svelte';
 	[
 		// TODO: get line and col num from input.svelte rather than hardcoding here
-		[css, '--keep-me', 13, 2],
-		// TODO: these should be 7, 2 and 10, 2
-		// we use locate_1 which means lines are 1-indexed and cols are 0-indexed
-		// each tab is 1 col
-		[css, '--done-replace-once', 6, 4],
-		[css, '--done-replace-twice', 9, 4]
-	].forEach(([where, content, line, column]) => {
+		[css, '--keep-me', null, 13, 2],
+		[css, '--done-replace-once', '--replace-me-once', 7, 2],
+		[css, '--done-replace-twice', '--replace-me-twice', 10, 2]
+	].forEach(([where, content, name, line, column]) => {
 		assert.deepEqual(
 			where.mapConsumer.originalPositionFor(where.locate_1(content)),
 			{
 				source: sourcefile,
-				name: null,
+				name,
 				line,
 				column
 			},

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml