Merge pull request #430 from sveltejs/disallow-import-root

disallow `import root` during validation
sveltejs · Apr 2, 2017 · 132de5c · 132de5c
2 parents 7c5eaa2 + f6934a1
commit 132de5c
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/src/validate/js/index.js b/src/validate/js/index.js
@@ -63,5 +63,13 @@ export default function validateJs ( validator, js ) {
 
 			validator.defaultExport = node;
 		}
+
+		if ( node.type === 'ImportDeclaration' ) {
+			node.specifiers.forEach( specifier => {
+				if ( specifier.local.name === 'root' ) {
+					validator.error( `Imported identifiers cannot have a name of 'root' due to technical limitations`, specifier.start );
+				}
+			});
+		}
 	});
 }
diff --git a/test/validator/samples/import-root/errors.json b/test/validator/samples/import-root/errors.json
@@ -0,0 +1,8 @@
+[{
+	"message": "Imported identifiers cannot have a name of 'root' due to technical limitations",
+	"pos": 17,
+	"loc": {
+		"line": 2,
+		"column": 8
+	}
+}]
diff --git a/test/validator/samples/import-root/input.html b/test/validator/samples/import-root/input.html
@@ -0,0 +1,3 @@
+<script>
+	import root from 'foo';
+</script>