fix: allow for non optional chain call expression in render (#11578)

sveltejs · May 13, 2024 · 81517a5 · 81517a5
1 parent 61238d0
commit 81517a5
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/.changeset/gentle-trees-exercise.md b/.changeset/gentle-trees-exercise.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: allow for non optional chain call expression in render
diff --git a/packages/svelte/src/compiler/phases/1-parse/state/tag.js b/packages/svelte/src/compiler/phases/1-parse/state/tag.js
@@ -587,9 +587,7 @@ function special(parser) {
 
 		if (
 			expression.type !== 'CallExpression' &&
-			(expression.type !== 'ChainExpression' ||
-				expression.expression.type !== 'CallExpression' ||
-				!expression.expression.optional)
+			(expression.type !== 'ChainExpression' || expression.expression.type !== 'CallExpression')
 		) {
 			e.render_tag_invalid_expression(expression);
 		}

diff --git a/packages/svelte/tests/runtime-runes/samples/snippet-expressions/_config.js b/packages/svelte/tests/runtime-runes/samples/snippet-expressions/_config.js
@@ -10,6 +10,10 @@ export default test({
 		<hr>
 		<p>foo</p>
 		<hr>
+		<p>foo</p>
+		<hr>
+		<p>foo</p>
+		<hr>
 		<p>bar</p>
 		<hr>
 		<hr>
@@ -35,6 +39,10 @@ export default test({
 				<p>foo</p>
 				<hr>
 				<p>foo</p>
+				<hr>
+				<p>foo</p>
+				<hr>
+				<p>foo</p>
 				<button>toggle</button>
 			`
 		);

diff --git a/packages/svelte/tests/runtime-runes/samples/snippet-expressions/child.svelte b/packages/svelte/tests/runtime-runes/samples/snippet-expressions/child.svelte
@@ -12,6 +12,10 @@
 <hr>
 {@render snippets.foo()}
 <hr>
+{@render snippets?.foo()}
+<hr>
+{@render snippets?.foo?.()}
+<hr>
 {@render snippets.foo?.()}
 <hr>
 {@render (optional ?? snippets.bar)()}