Skip to content

Commit

Permalink
fix code review
Browse files Browse the repository at this point in the history
  • Loading branch information
tanhauhau committed Jun 18, 2021
1 parent 0622e23 commit 841137a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/runtime/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('runtime', () => {
throw new Error('Forgot to remove `solo: true` from test');
}

const testName = `${dir} ${hydrate ? `(with hydration ${from_ssr_html ? 'from ssr rendered html' : ''})` : ''}`;
const testName = `${dir} ${hydrate ? `(with hydration${from_ssr_html ? ' from ssr rendered html' : ''})` : ''}`;
(config.skip ? it.skip : solo ? it.only : it)(testName, () => {
if (failed.has(dir)) {
// this makes debugging easier, by only printing compiled output once
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ export default {
indeterminate: true
},

html: '<input type=\'checkbox\'>',
html: "<input type='checkbox'>",

// somehow ssr will render indeterminate=""
// the hydrated html will still contain that attribute
ssrHtml: '<input type=\'checkbox\' indeterminate="">',
ssrHtml: "<input type='checkbox' indeterminate=''>",

test({ assert, component, target }) {
const input = target.querySelector('input');
Expand Down

0 comments on commit 841137a

Please sign in to comment.