Add mount condition for playbackRate and volume

sveltejs · Nov 12, 2019 · ed4f89d · ed4f89d
1 parent 92710f8
commit ed4f89d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/compiler/compile/render_dom/wrappers/Element/Binding.ts b/src/compiler/compile/render_dom/wrappers/Element/Binding.ts
@@ -140,6 +140,7 @@ export default class BindingWrapper {
 			case 'playbackRate':
 			case 'volume':
 				update_conditions.push(x`!@_isNaN(${this.snippet})`);
+				mount_conditions.push(x`!@_isNaN(${this.snippet})`);
 				break;
 
 			case 'paused':

diff --git a/test/js/samples/media-bindings/expected.js b/test/js/samples/media-bindings/expected.js
@@ -58,8 +58,14 @@ function create_fragment(ctx) {
 		},
 		m(target, anchor) {
 			insert(target, audio, anchor);
-			audio.volume = ctx.volume;
-			audio.playbackRate = ctx.playbackRate;
+
+			if (!isNaN(ctx.volume)) {
+				audio.volume = ctx.volume;
+			}
+
+			if (!isNaN(ctx.playbackRate)) {
+				audio.playbackRate = ctx.playbackRate;
+			}
 		},
 		p(changed, ctx) {
 			if (!audio_updating && changed.currentTime && !isNaN(ctx.currentTime)) {