Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component.set doesn't update ui when called from an awaiting promise #1131

Closed
jamesbirtles opened this issue Jan 25, 2018 · 1 comment · Fixed by #1150
Closed

component.set doesn't update ui when called from an awaiting promise #1131

jamesbirtles opened this issue Jan 25, 2018 · 1 comment · Fixed by #1150
Labels
bug

Comments

@jamesbirtles
Copy link
Contributor

Repro: https://svelte.technology/repl?version=1.53.0&gist=bfd178f583f0be414daadb871a1e18d6

As shown in the repl, when calling this.set at the end of the awaited promise's chain, it fails to update the ui. The second button with the setTimeout works (albeit with a flash).
@Conduitry Conduitry added the bug label Jan 25, 2018
Rich-Harris added a commit that referenced this issue Feb 4, 2018
@Rich-Harris
prevent await blocks using stale state - fixes #1131
bf25248
@Rich-Harris Rich-Harris mentioned this issue Feb 4, 2018
Merged
Rich-Harris added a commit that referenced this issue Feb 4, 2018
@Rich-Harris
Merge pull request #1150 from sveltejs/gh-1131
29a1569 
prevent await blocks using stale state
@Rich-Harris
Copy link
Member

This is fixed in 1.54.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent await blocks using stale state sveltejs/svelte
3 participants
@Rich-Harris @jamesbirtles @Conduitry