New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression 1.60.1 -> 1.60.2 :: <select multiple... results in Module build failed #1331

Closed

samhatchett opened this issue Apr 11, 2018 · 1 comment

Labels

bug

samhatchett commented Apr 11, 2018 •

edited

Loading

https://svelte.technology/repl?version=1.60.2&gist=3d32d3e082562a4de08b054f46e7756e

The example works with v 1.60.1 but not with 1.60.2.

I believe this is due to incorrect flow here:
https://github.com/sveltejs/svelte/blob/master/src/validate/html/validateElement.ts#L110

... from the PR meant to address generating a compiler error for dynamic binding of multiple:
https://github.com/sveltejs/svelte/pull/1313/files#diff-af8fdb1fcadd89d16ba4cf8722fe1eafR116

Looks like checkTypeAttribute is never called for a non-dynamic multiple

The text was updated successfully, but these errors were encountered:

Rich-Harris added the bug label

samhatchett mentioned this issue

attempts to fix #1331 #1332

Closed

Rich-Harris closed this as completed in

032083b

Rich-Harris added a commit that referenced this issue


          Merge pull request #1333 from sveltejs/gh-1331

5c956dd

fix #1331

Member

Rich-Harris commented Apr 12, 2018

Thanks, fixed in 1.60.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment