Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate onerror #1745

Closed
Rich-Harris opened this issue Sep 15, 2018 · 1 comment · Fixed by #1759
Closed

Deprecate onerror #1745

Rich-Harris opened this issue Sep 15, 2018 · 1 comment · Fixed by #1759
Milestone
3.0

Comments

@Rich-Harris
Copy link
Member

There's no value in a user-supplied onerror — it's not like onwarn where you can filter out warnings you don't want to deal with. An error is an error. The user should wrap svelte.compile in a try-catch block.

I think we should noisily deprecate it, and remove it in v3.
@Rich-Harris Rich-Harris added this to the 3.x milestone Sep 15, 2018
Rich-Harris added a commit that referenced this issue Sep 26, 2018
@Rich-Harris
deprecate onerror - fixes #1745
bf50b47
@Rich-Harris Rich-Harris mentioned this issue Sep 26, 2018
Merged
Rich-Harris added a commit that referenced this issue Oct 17, 2018
@Rich-Harris
Merge pull request #1759 from sveltejs/gh-1745
f1204bf 
deprecate onerror
@Conduitry
Copy link
Member

This should be reflected in the table of compiler options in the readme. Perhaps remove it outright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

deprecate onerror sveltejs/svelte
2 participants
@Rich-Harris @Conduitry