Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent onDestroy #3058

Closed
tienpv222 opened this issue Jun 20, 2019 · 1 comment · Fixed by #3097
Closed

Inconsistent onDestroy #3058

tienpv222 opened this issue Jun 20, 2019 · 1 comment · Fixed by #3097
Labels
bug

Comments

@tienpv222
Copy link
Contributor

tienpv222 commented Jun 20, 2019 •
edited
Loading

Repl: https://svelte.dev/repl/baabdbdeeac843fe9662903809f61ddb?version=3.5.3

Step to reproduce:

  • Open console
  • Click Toggle

The logs from the two components should be the same, but they are not.
Edit: This happened since 3.5.2
@tienpv222 tienpv222 mentioned this issue Jun 20, 2019
Closed
Rich-Harris added a commit that referenced this issue Jun 24, 2019
@Rich-Harris
always run onDestroy functions - fixes #3058
0e90ddc
@Rich-Harris Rich-Harris mentioned this issue Jun 24, 2019
Merged
Rich-Harris added a commit that referenced this issue Jun 24, 2019
@Rich-Harris
Merge branch 'master' into gh-3058
5981be8
Rich-Harris added a commit that referenced this issue Jun 24, 2019
@Rich-Harris
Merge pull request #3097 from sveltejs/gh-3058
8431aff 
always run onDestroy functions
@Rich-Harris
Copy link
Member

Fixed in 3.6.0 — thanks

@frederikhors frederikhors mentioned this issue Jun 25, 2019
Closed
This was referenced Sep 17, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

always run onDestroy functions sveltejs/svelte
2 participants
@Rich-Harris @tienpv222