Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!doctype causes an error #336

Closed
thoughtspile opened this issue Mar 5, 2017 · 4 comments
Closed

!doctype causes an error #336

thoughtspile opened this issue Mar 5, 2017 · 4 comments
Labels
bug

Comments

@thoughtspile
Copy link

Currently, <!DOCTYPE html> raises an error (!DOCTYPE was left open). This is probably only relevant to SSR.
(REPL)[https://svelte.technology/repl/?version=1.10.0&gist=881e409ef1a972e7a86e9a1748ced90e]
@thoughtspile thoughtspile changed the title Handle doctype !doctype causes an error Mar 5, 2017
@Conduitry Conduitry mentioned this issue Mar 6, 2017
Closed
@Conduitry
Copy link
Member

This was actually a case sensitivity issue. <!doctype html> parsed fine, but <!DOCTYPE html> threw an error. Should be resolved by #340

@Conduitry
Copy link
Member

Bumped into some issues in #340. In the meantime, just using lowercase for the element name will work around this.

@Conduitry Conduitry mentioned this issue Mar 6, 2017
Closed
@Rich-Harris
Copy link
Member

We could make a special case for doctype, since it's not uncommon to see it uppercased — treating it as a void element is a bit of a hack in the first place

@Rich-Harris Rich-Harris added the bug label Mar 6, 2017
@Conduitry Conduitry mentioned this issue Mar 6, 2017
Merged
@Conduitry
Copy link
Member

That sounds like a good compromise for now, just submitted a PR

Rich-Harris added a commit that referenced this issue Mar 6, 2017
@Rich-Harris
Merge pull request #346 from sveltejs/gh-336-accept-doctype-in-any-case
9ae74d9 
accept DOCTYPE element in any case
@matthewmueller matthewmueller mentioned this issue Jun 18, 2020
Closed
@jimafisk jimafisk mentioned this issue Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make void element test case insensitive sveltejs/svelte
3 participants
@Rich-Harris @thoughtspile @Conduitry