Try to better catch failures to used aliased names in unit tests

[Conduitry]

I'm not sure exactly what this would look like. But it would be nice if unit tests were better at catching things like using component directly when you should be using ${block.component} because it may have been renamed. My initial idea is to, during unit tests, make the get unique name methods add some random string to each name they generate, to try to break code that's failing to use the proper alias.

[Conduitry]

diff --git a/src/generators/Generator.js b/src/generators/Generator.js
index 272e843..b89da12 100644
--- a/src/generators/Generator.js
+++ b/src/generators/Generator.js
@@ -238,6 +238,7 @@ export default class Generator {
        }

        getUniqueName ( name ) {
+               name += '_BREAK_SHIT';
                let alias = name;
                for ( let i = 1; reservedNames.has( alias ) || this.importedNames.has( alias ) || this._usedNames.has( alias ); alias = `${name}_${i++}` );
                this._usedNames.add( alias );
@@ -247,6 +248,7 @@ export default class Generator {
        getUniqueNameMaker ( params ) {
                const localUsedNames = new Set( params );
                return name => {
+                       name += '_BREAK_SHIT';
                        let alias = name;
                        for ( let i = 1; reservedNames.has( alias ) || this.importedNames.has( alias ) || this._usedNames.has( alias ) || localUsedNames.has( alias ); alias = `${name}_${i++}` );
                        localUsedNames.add( alias );

Ran unit tests with this just as a quick little test. As advertised it does indeed break shit, but some may be false positives.

[Rich-Harris]

Excellent point, thanks for being vigilant about this stuff. I seem to have a blind spot for it 😀 Started work over on #468

[Rich-Harris]

Will close this as I think we're in a pretty good place now