Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

% signs are output as undefined #868

Closed
ekhaled opened this issue Sep 22, 2017 · 1 comment
Closed

% signs are output as undefined #868

ekhaled opened this issue Sep 22, 2017 · 1 comment
Assignees
@Conduitry
Labels
bug

Comments

@ekhaled
Copy link
Contributor

ekhaled commented Sep 22, 2017

% signs are output as undefined

look at all the undefined in the generated code here: https://svelte.technology/repl?version=1.40.0&gist=47569a1f3751ef0102e443e0626b42b3
@Conduitry Conduitry self-assigned this Sep 22, 2017
@Conduitry Conduitry added the bug label Sep 22, 2017
Conduitry added a commit that referenced this issue Sep 22, 2017
@Conduitry
fix sigil escaping in .textContent and .innerHTML (#868)
707405a
@Conduitry Conduitry mentioned this issue Sep 22, 2017
Merged
Rich-Harris added a commit that referenced this issue Sep 23, 2017
@Rich-Harris
Merge pull request #869 from sveltejs/gh-868
54bbeea 
Escape sigils in .textContent and .innerHTML
@Rich-Harris
Copy link
Member

My bad, sorry — fixed in 1.40.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Conduitry Conduitry

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ekhaled @Rich-Harris @Conduitry