Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fire oncreate handlers for components inside await blocks #1094

Merged
merged 1 commit into from
Jan 13, 2018

Conversation

Rich-Harris
Copy link
Member

Ref #1061. Between this and #1093 we might have everything covered.

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #1094 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1094   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         123      123           
  Lines        4477     4477           
  Branches     1443     1443           
=======================================
  Hits         4098     4098           
  Misses        162      162           
  Partials      217      217
Impacted Files Coverage Δ
src/generators/nodes/AwaitBlock.ts 94.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cfa174...c1b5bed. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 49bc092 into master Jan 13, 2018
@Rich-Harris Rich-Harris deleted the gh-1061-b branch January 13, 2018 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants