Fix order of oncreate
in sibling components
#1137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1135 by running
oncreate
hooks (and associatedbeforecreate
andaftercreate
) front to back instead of back to front. We have to tweak the initialisation code to preserve the depth-first behaviour, which people might be relying on (there's a test that says as much).This does change one piece of behaviour in a way that might be unexpected — if you have uninitialised bindings like this...
...the binding of
y
will initialise to the opposite value than what it did before. Uninitialised bindings inside conditionals is a terrible idea that is easily fixed by the user, so I don't feel bad about that.