use setAttribute with inputs, for benefit of IE - fixes #1209 #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 126 126
Lines 4570 4570
Branches 1493 1493
=======================================
Hits 4192 4192
Misses 157 157
Partials 221 221
Continue to review full report at Codecov.
|
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the straightforward fix for #1209. I didn't put it behind the
legacyoption because IE11 probably doesn't qualify as legacy (sadly) — it's not quite as nice as using the accessor but I think it's an acceptable solution.