Speed up keyed swap rows benchmark by moving existing DOM elements instead of creating new elements #1249
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1249 +/- ##
=========================================
+ Coverage 91.9% 91.9% +<.01%
=========================================
Files 126 126
Lines 4556 4559 +3
Branches 1486 1486
=========================================
+ Hits 4187 4190 +3
Misses 153 153
Partials 216 216
Continue to review full report at Codecov.
|
btakita
force-pushed
the
issues/588
branch
7 times, most recently
from
ceade29
to
17c9b3a
Compare
* Performance Improvement with Keyed EachBlock
* All DOM nodes for existing data are reused between changes to state
* Speed up Keyed Swap Rows Benchmark
* https://github.com/krausest/js-framework-benchmark
* Fixed Build
* Introduced jsdom.VirtualConsole
|
This is amazing! If I've understood correctly, you managed to speed up the swapping rows case without negatively impacting anything else, while reducing the amount of code. I ran js-framework-benchmark on this branch and compared it to 1.57.4 — looks like good news all round: http://windy-able.surge.sh/ Thanks so much! |
|
(One small observation — some of the hard-coded variable names are vulnerable to conflicts. I haven't edited those yet because I want to see if it's possible to extract this stuff into a helper function instead.) |
#588