Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disregard TypeScript nodes when pruning CSS #14276

Closed
wants to merge 1 commit into from
Closed

Conversation

Rich-Harris
Copy link
Member

fixes #14204

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 1aa8707

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

preview: https://svelte-dev-git-preview-svelte-14276-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14276

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix the root cause of the problem, and so other subtle bugs could occur.
Let's say you have this:

<div>
  <p foo={true as false}>hi</p>
</div>

The AST is something like this

{
  type: 'RegularElement',
  name: 'div',
  children: {
    type: 'RegularElement';
    name: 'p';
    parent: the_upper_div_node;
    attributes: [{ type: 'TSASExpression'; ... }]
  }
}

Now if the "strip TS types" visitor runs, it replaces all nodes that have changed nodes etc.
Therefore because TSASExpression is stripped, the p node is replaced with a new object, and so is the div object. But p_node.parent still points to the old div object from before. So now you have two different nodes in there, and p_node.parent !== div_node which is wrong. Just a matter of time until something else goes subtly wrong because of things not matching up correctly - so the fix has to be to rewire p_node.parent to the new div AST node

@Rich-Harris
Copy link
Member Author

merged #14395, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong CSS "Unused CSS selector"
2 participants