Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify css pruning slightly #14432

Merged
merged 1 commit into from
Nov 25, 2024
Merged

chore: simplify css pruning slightly #14432

merged 1 commit into from
Nov 25, 2024

Conversation

Rich-Harris
Copy link
Member

trying to extract small changes out into separate PRs so that the eventual PR addressing #14399 doesn't contain too many changes.

In get_possible_element_siblings, if we encounter a preceding element and adjacent_only is true, we can return immediately instead of breaking. Since there's no break, prev is always undefined after the first loop has run, meaning we always need to run the second loop.

Will instamerge to unblock the other work

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: 60dfc89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member Author

preview: https://svelte-dev-git-preview-svelte-14432-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14432

@Rich-Harris Rich-Harris merged commit 4f0dde5 into main Nov 25, 2024
11 checks passed
@Rich-Harris Rich-Harris deleted the simplify-css-pruning branch November 25, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant