Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1440 await blocks gets out of order #1858

Merged
merged 3 commits into from
Dec 15, 2018
Merged

Fixes #1440 await blocks gets out of order #1858

merged 3 commits into from
Dec 15, 2018

Conversation

RedHatter
Copy link
Contributor

Added a failing test for async blocks getting out of order in some situations as shown in #1440.

@RedHatter
Copy link
Contributor Author

RedHatter commented Nov 20, 2018 •
edited
Loading

The problem was info.anchor being unset in newer version (after 2.5.0). Previously await blocks were anchored against text. I don't know if this is the most elegant solution, but it works!

@RedHatter RedHatter changed the title Failing test for async block ordering (#1440) Fixes #1440 Nov 20, 2018
@RedHatter RedHatter changed the title Fixes #1440 Fixes #1440 await blocks gets out of order Nov 20, 2018
@Rich-Harris Rich-Harris merged commit 68c2a34 into sveltejs:master Dec 15, 2018
@Rich-Harris
Copy link
Member

thank you!

@RedHatter RedHatter deleted the await-then-catch-order branch December 15, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RedHatter @Rich-Harris