fix invalidating stores with UpdateExpression #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2625. Also dries up the invalidation code a bit. It was in fact an imperfect mirroring of the
AssignmentExpressionbranch in theUpdateExpressionbranch that was causing this bug.Possible future optimization: Also allowNever mind, we're further from this than I thought.UpdateExpressions to get thesingletreatment here if they areprefix: trueor if we can safely convert them toprefix: truebecause their value is currently discarded.$foo += 42;also does not currently get optimized this way. Maybe someday.