Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on improper use of reactive declarations #2679

Merged
merged 1 commit into from
May 6, 2019
Merged

Warn on improper use of reactive declarations #2679

merged 1 commit into from
May 6, 2019

Conversation

EmilTholin
Copy link
Member

@EmilTholin EmilTholin commented May 4, 2019

This PR makes it so a warning is raised when a reactive declaration is used in a module script, or when it is used at a non-top-level in an instance script.

Closes #2176.

@Rich-Harris Rich-Harris merged commit 4bc93a3 into sveltejs:master May 6, 2019
@Rich-Harris
Copy link
Member

🙌

@EmilTholin EmilTholin deleted the reactive-declaration-warnings branch May 6, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warnings for non-top-level reactive declarations
2 participants