Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4061 where changes to let directives where not being passed to nested slots. I feel like I'm missing something though. Why was filtering let dependencies (
non_let_dependencies
) thought to be necessary in the first place?In light of this fix I'm also suspicious of lines 94-103
It looks to be doing something similar but I'm not sure what its exact effect is. The issue is solved without removing line 98 but I wonder if it's causing some other subtle bug.