Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4240 #4247

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Issue 4240 #4247

merged 3 commits into from
Jan 13, 2020

Conversation

jesseskinner
Copy link
Contributor

Fixes #4240.

In ssr.ts, JSON.stringify was being used to encode the values of attributes. This was causing actual JavaScript/JSON escape values to be written into the HTML. This fix changes it so it concatenates double quotes before and after String(value) instead.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Conduitry Conduitry merged commit e3d6686 into sveltejs:master Jan 13, 2020
jesseskinner added a commit to jesseskinner/svelte that referenced this pull request Feb 27, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White space escape characters are written into HTML when spread is used with SSR
2 participants