fix binding to module-level variables #4352
Merged
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
commented
Feb 3, 2020
| <script> | ||
| import { onMount } from 'svelte'; | ||
| let bar; | ||
| onMount(() => bar = foo); |
There was a problem hiding this comment.
If there's a nicer way to find out in the test what the value of the module-level foo variable is once the component's mounted, I couldn't find it.
sthagen
added a commit
to sthagen/sveltejs-svelte
that referenced
this pull request
Feb 3, 2020
fix binding to module-level variables (sveltejs#4352)
kaisermann
pushed a commit
to kaisermann/svelte
that referenced
this pull request
Feb 6, 2020
jesseskinner
pushed a commit
to jesseskinner/svelte
that referenced
this pull request
Feb 27, 2020
taylorzane
pushed a commit
to taylorzane/svelte
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4086. I looked a bit into the other optimizations I mentioned in that issue, but I don't think they're worth the effort for now, especially since binding to module-level variables is kind of a weird and niche thing to be doing anyway.