Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not initialise slot fallback fragment unless necessary #4514

Merged
merged 4 commits into from
Mar 15, 2020
Merged

do not initialise slot fallback fragment unless necessary #4514

merged 4 commits into from
Mar 15, 2020

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Mar 6, 2020 •
edited
Loading

Fixes #3763

  • also move the fallback fragment creation logic into it's own block

@tanhauhau tanhauhau added the slot label Mar 6, 2020
@tanhauhau tanhauhau force-pushed the tanhauhau/slot-fallback-fragment branch 2 times, most recently from 5f52146 to 1862c95 Compare March 6, 2020 14:04
@tanhauhau tanhauhau force-pushed the tanhauhau/slot-fallback-fragment branch from 1862c95 to eb40158 Compare March 6, 2020 17:48
@Conduitry Conduitry merged commit 82dce0c into sveltejs:master Mar 15, 2020
@tanhauhau tanhauhau deleted the tanhauhau/slot-fallback-fragment branch March 15, 2020 09:57
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
do not initialise slot fallback fragment unless necessary (sveltejs#4514
e50b5d8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested slots with default value and store: Cannot read property 'value' of undefined
2 participants
@tanhauhau @Conduitry