Add accessible-emoji a11y check #4805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
May 8, 2020
| const { data, component, parent } = this; | ||
|
|
||
| // https://github.com/mathiasbynens/emoji-regex/blob/master/src/index.js | ||
| const emoji_regex =/<% emojiSequence %>|\p{Emoji_Presentation}|\p{Emoji}\uFE0F|\p{Emoji_Modifier_Base}/gu; |
There was a problem hiding this comment.
Even though it's now EOL, Node 8 is still officially supported by Svelte 3, which means we can't use regex features like this - and this is failing CI which is running on Node 8, 10, 12, and 14.
There's also a previous PR #4411 for this that's been languishing for a little bit, but which is compatible with Node 8.
There was a problem hiding this comment.
Oops - completely forgot to check for existing PRs. In that case I'll close this one. Thanks :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warns if an emoji isn't accessible i.e. not wrapped in a
<span>withrole="img"andaria-label. More infoPart of the list in #820